After years of selling the stock market as a reliable path to riches, CNBC’s star stock-picker has received brutal criticism recently from viewers and competitors.